Backport from other branches #802
Conversation
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
============================================
+ Coverage 83.06% 92.42% +9.36%
============================================
Files 142 24 -118
Lines 11813 1453 -10360
Branches 4454 0 -4454
============================================
- Hits 9812 1343 -8469
+ Misses 1248 110 -1138
+ Partials 753 0 -753
Continue to review full report at Codecov.
|
|
This is targeting release 1.1.x as it does things to the backend that constitute a substantial change (though it shouldn't be reflected in the API.) It will take a while to get all the bugs out as it touches the boot loader path. After this point we won't have to do special magic to register the native entry points and our jar file will be accessable outside the module (which doesn't do much until I complete the rest of Python from Java patch.) |
Thrameos
added
the
enhancement
|
@marscher This one is finally ready for review. This won't be applied until 1.1 as it is rearranging stuff having to do with thunks. It is a prerequisite for a few future enhancements as it cleans up a bunch of core issues and makes native linking much easier. |
|
Working to resolve the conflict. Will take a bit as it is a structural difference in the load procedure that needs to be resolved. |
|
Is this review complete? |
|
Sorry I've added some points in the meantime. |
|
@marsher So I have added a bunch of PRs that could go in that could form a patch release as well as few that are built on this as a base. I have tried to label which are which by the milestone. If you see something that isn't appropriate for a patch release you can add the milestone to it. So we may need to come up with some other way to indicate it. In the mean time, I have been trying to identify some of the user needs by soliciting input from some of the other github projects. Bayer-Group/paquo#33 and scijava/scyjava#18. It has given me a few ideas that we may be able to apply. |
|
|
||
|
|
||
| def read_utf8(path, *parts): | ||
| filename = os.path.join(os.path.dirname(path), *parts) | ||
| return codecs.open(filename, encoding='utf-8').read() | ||
|
|
||
|
|
||
| def find_sources(): | ||
| def find_sources(roots=[]): |
There was a problem hiding this comment.
Awooga! I just bisected an issue (to be raised shortly) which points back to this commit. I have no idea if the problem is related to this, but I was quickly reviewing the code and saw this. I'm sure you already know about the pitfalls of mutable defaults with Python, and that they are a no-go unless you really intend them.
This is a backport of changes from future branches.